iro/model/schema.py
author Sandro Knauß <knauss@netzguerilla.net>
Mon, 13 Feb 2012 18:00:27 +0100
branchdevel
changeset 150 c6896c3374c4
parent 148 11e0fdc1a58c
child 153 0e50d10c8b6c
permissions -rw-r--r--
more offer tests an fixes in model.schema
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
     1
# -*- coding: utf-8 -*- 
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
     2
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
     3
from sqlalchemy import Column, Integer, String, Sequence, Boolean, DateTime, Numeric, Enum
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
     4
from sqlalchemy.ext.declarative import declarative_base
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
     5
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
     6
#relationship
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
     7
from sqlalchemy import ForeignKey
121
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
     8
from sqlalchemy.orm import relationship, backref, object_session
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
     9
127
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    10
from sqlalchemy import and_
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    11
import sqlalchemy.sql.functions as func
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    12
140
75d0eaaa871d start fixing job mangement
Sandro Knauß <knauss@netzguerilla.net>
parents: 136
diff changeset
    13
import job
125
19b3f383c9ce getting job status form db
Sandro Knauß <knauss@netzguerilla.net>
parents: 122
diff changeset
    14
from ..error import JobNotFound
19b3f383c9ce getting job status form db
Sandro Knauß <knauss@netzguerilla.net>
parents: 122
diff changeset
    15
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    16
Base = declarative_base()
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    17
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    18
__tables__=["User", "Job", "Message", "Offer", "Userright"]
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    19
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    20
class Userright(Base):
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    21
    """Über welche Routen darf ein Benutzer Daten verschicken und welches sind die Standardrouten (<em>isDefault=1</em>) für den Benuter."""
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    22
    __tablename__ = 'userright'
94
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    23
    user_name = Column('user', String(100), ForeignKey('apiuser.name'), primary_key=True)
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    24
    offer_name = Column('offer', String(100), ForeignKey('offer.name'), primary_key=True)
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    25
    isDefault = Column(Boolean)
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    26
    offer = relationship("Offer")
127
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    27
    user = relationship("User")
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    28
117
351a02310dd8 model restructuring
Sandro Knauß <knauss@netzguerilla.net>
parents: 94
diff changeset
    29
    def __init__(self, offer, default=False):
351a02310dd8 model restructuring
Sandro Knauß <knauss@netzguerilla.net>
parents: 94
diff changeset
    30
        self.offer = offer
351a02310dd8 model restructuring
Sandro Knauß <knauss@netzguerilla.net>
parents: 94
diff changeset
    31
        self.isDefault = default
351a02310dd8 model restructuring
Sandro Knauß <knauss@netzguerilla.net>
parents: 94
diff changeset
    32
127
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    33
    @property
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    34
    def bill(self):
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    35
        '''getting a list of unbilled messages grouped by Job.info'''
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    36
        query = [ func.count(Message.id).label('anz'),      # anz of messages
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    37
                  func.sum(Message.price).label("price"),   # price of the messages
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    38
                  Job.info.label('info'),                   # info tag
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    39
                  ]
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    40
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    41
        filters = [ Message.isBilled==False,                # only unbilled messages
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    42
                   Job.user==self.user,                     # only jobs connected to user
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    43
                   Message.offer==self.offer,               # only messages in the right offer
136
ca926774e16c now using job.id - integer autoincrement
Sandro Knauß <knauss@netzguerilla.net>
parents: 135
diff changeset
    44
                   Message.job_id==Job.id,                  # join Message and Job
127
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    45
                ]
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    46
        return object_session(self).query(*query).filter(and_(*filters)).group_by(Job.info)
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    47
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    48
class Offer(Base):
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    49
    """Alle Routen über die SMS, Faxe und Mails verschickt werden könnnen. <em>provider</em>, <em>typ</em> und <em>route</em> werden verwendet, um die entsprechenden Zugangsdaten laden zu können."""
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    50
    __tablename__ = "offer"
94
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    51
    name = Column(String(100), primary_key=True)
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    52
    provider = Column(String(100))
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    53
    route = Column(String(100))
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    54
    typ = Column(String(100))
122
b55754aa4f96 nun typs query into session object
Sandro Knauß <knauss@netzguerilla.net>
parents: 121
diff changeset
    55
  
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    56
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    57
class Message(Base):
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    58
    """Wenn ein Vorgang von Iro Kosten erzeugt hat wird eine neue Zeile eingefügt. Solange nicht bezahlt wurde ist <em>isBilled=0</em>."""
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    59
    __tablename__ = "message"
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    60
    id = Column(Integer, Sequence('message_id_seq'), primary_key=True)
94
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    61
    recipient = Column(String(100))
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    62
    isBilled = Column(Boolean)
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    63
    date = Column(DateTime)
127
79966b937274 made bill (aka statistic) function ready
Sandro Knauß <knauss@netzguerilla.net>
parents: 125
diff changeset
    64
    price = Column(Numeric(8,4))
136
ca926774e16c now using job.id - integer autoincrement
Sandro Knauß <knauss@netzguerilla.net>
parents: 135
diff changeset
    65
    job_id = Column("job", String(40), ForeignKey('job.id'))
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    66
    job = relationship("Job", backref=backref('messages'))
94
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    67
    offer_id = Column("offer",String(100), ForeignKey('offer.name'))
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    68
    offer = relationship("Offer", backref=backref('messages'))
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    69
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    70
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    71
class Job(Base):
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    72
    """Ein kompletter Auftrag, der an Iro zum verschicken übergeben wird. Status zeigt den generellen Status des Auftrages an (<em>init</em>, <em>started</em>, <em>sending</em>, <em>sended</em> oder <em>error</em>). <em>info</em> wird verwendet um dem Benutzer eine Möglickeit zu geben verschiede Auftragsgruppen zu erstellen."""
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    73
    __tablename__ = "job"
136
ca926774e16c now using job.id - integer autoincrement
Sandro Knauß <knauss@netzguerilla.net>
parents: 135
diff changeset
    74
    id = Column(Integer, Sequence('job_id_seq'), primary_key=True)
94
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    75
    info = Column(String(100))
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    76
    status = Column(Enum("init","started","sending","sended","error"))
94
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    77
    user_id = Column("user", String(100), ForeignKey('apiuser.name'))
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    78
    user = relationship("User", backref=backref('jobs'))
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    79
140
75d0eaaa871d start fixing job mangement
Sandro Knauß <knauss@netzguerilla.net>
parents: 136
diff changeset
    80
    @property
75d0eaaa871d start fixing job mangement
Sandro Knauß <knauss@netzguerilla.net>
parents: 136
diff changeset
    81
    def extend(self):
75d0eaaa871d start fixing job mangement
Sandro Knauß <knauss@netzguerilla.net>
parents: 136
diff changeset
    82
        return job.exJobs[self.id]
75d0eaaa871d start fixing job mangement
Sandro Knauß <knauss@netzguerilla.net>
parents: 136
diff changeset
    83
75d0eaaa871d start fixing job mangement
Sandro Knauß <knauss@netzguerilla.net>
parents: 136
diff changeset
    84
135
f8640c663e3e model.job created
Sandro Knauß <knauss@netzguerilla.net>
parents: 127
diff changeset
    85
    def __repr__(self):
136
ca926774e16c now using job.id - integer autoincrement
Sandro Knauß <knauss@netzguerilla.net>
parents: 135
diff changeset
    86
        return "<Job('%s','%s','%s','%s')>"%(self.id,self.info, self.status, self.user_id)
135
f8640c663e3e model.job created
Sandro Knauß <knauss@netzguerilla.net>
parents: 127
diff changeset
    87
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    88
class User(Base):
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    89
    """Die Benutzerdatenbank von Iro. <em>ng_kunde</em> ist der verknüpfte netzguerilla.net Benutzer, der die Rechnung zahlt."""
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    90
    __tablename__ = "apiuser"
94
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    91
    name = Column(String(100), primary_key=True)
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    92
    ng_kunde = Column(Integer)
94
4349f10d77a6 updatating schema for mysql
Sandro Knauß <knauss@netzguerilla.net>
parents: 92
diff changeset
    93
    apikey = Column(String(50),unique=True)
92
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    94
    rights = relationship('Userright')
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    95
    def __init__(self, name, apikey):
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    96
        self.name=name
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    97
        self.apikey=apikey
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    98
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
    99
    def __repr__(self):
f479738b4879 umbau zu MVC
Sandro Knauß <knauss@netzguerilla.net>
parents:
diff changeset
   100
        return "<User('%s','%s')>"%(self.name,self.apikey)
121
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
   101
    
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
   102
    def routes(self, typ, isDefault = None):
148
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   103
        '''returns a query object to get all possible routes for a given typ'''
121
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
   104
        filters=[User.name == self.name,
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
   105
                Offer.typ == typ, 
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
   106
                ]
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
   107
        if isDefault is not None:
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
   108
            filters.append(Userright.isDefault==isDefault)
ca63b6776231 putting routes logic to schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 117
diff changeset
   109
        return object_session(self).query(Userright.offer_name).join(Offer,User).filter(and_(*filters))
148
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   110
   
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   111
    def providers(self, typ, isDefault = None):
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   112
        '''return a query object for all possible providers for a given typ'''
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   113
        filters=[User.name == self.name,
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   114
                Offer.typ == typ, 
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   115
                ]
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   116
        if isDefault is not None:
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   117
            filters.append(Userright.isDefault==isDefault)
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   118
        return object_session(self).query(Offer.provider).join(Userright,User).filter(and_(*filters))
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   119
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   120
    def has_right(self, typ, offer_name = None, provider = None, route = None):
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   121
        '''returns offer_name, if the user is allowed to use offer otherwise None
150
c6896c3374c4 more offer tests an fixes in model.schema
Sandro Knauß <knauss@netzguerilla.net>
parents: 148
diff changeset
   122
           ->raise sqlalchemy.orm.exc.MultipleResultsFound if not a single offer match'''
148
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   123
        filters=[User.name == self.name,
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   124
                Offer.typ == typ, 
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   125
                ]
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   126
        if offer_name:
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   127
            filters.append(Userright.offer_name==offer_name)
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   128
        if provider:
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   129
            filters.append(Offer.provider==provider)
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   130
        if route:
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   131
            filters.append(Offer.route==route)
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   132
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   133
        return object_session(self).query(Userright.offer_name).join(Offer,User).filter(and_(*filters)).scalar()
11e0fdc1a58c fill extendProvider with life
Sandro Knauß <knauss@netzguerilla.net>
parents: 140
diff changeset
   134
125
19b3f383c9ce getting job status form db
Sandro Knauß <knauss@netzguerilla.net>
parents: 122
diff changeset
   135
    def job(self, id):
136
ca926774e16c now using job.id - integer autoincrement
Sandro Knauß <knauss@netzguerilla.net>
parents: 135
diff changeset
   136
        job = object_session(self).query(Job).join(User).filter(and_(User.name == self.name, Job.id==id)).first()
125
19b3f383c9ce getting job status form db
Sandro Knauß <knauss@netzguerilla.net>
parents: 122
diff changeset
   137
        if job is None:
19b3f383c9ce getting job status form db
Sandro Knauß <knauss@netzguerilla.net>
parents: 122
diff changeset
   138
            raise JobNotFound()
19b3f383c9ce getting job status form db
Sandro Knauß <knauss@netzguerilla.net>
parents: 122
diff changeset
   139
        return job